-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completion: add zsh #653
Merged
Merged
completion: add zsh #653
Commits on Aug 7, 2022
-
github: shellcheck: bump from 1.1.0 to latest commit
We were already using the latest released version of this action, but it runs shellcheck on files ending in `.zsh`. Shellcheck does not support zsh, so this produces an error. The latest release of the action only supports ignoring directories, not files. And we shouldn't ignore the completions directory, because we want to run shellcheck on the `configlet.bash` completion script. For now, it looks like the best solution is to bump to the latest ref (2021-11-14). This includes an upstream commit [1] that is supposed to exclude `.zsh` files, but it doesn't seem to work. We need to use the `ignore_names` input that does not exist in the latest release. Running shellcheck on `configlet.zsh` produces these errors: In completions/configlet.zsh line 1: #compdef configlet ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In completions/configlet.zsh line 25: words=($line[1] "${words[@]}") ^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). ^---^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In completions/configlet.zsh line 27: curcontext="${curcontext%:*:*}:configlet-command-$line[1]:" ^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). In completions/configlet.zsh line 28: case $line[1] in ^-- SC1087 (error): Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). In completions/configlet.zsh line 95: (( $+functions[_configlet_commands] )) || ^----------------------------^ SC2154 (warning): functions is referenced but not assigned. ^-----------------^ SC2154 (warning): _configlet_commands is referenced but not assigned. In completions/configlet.zsh line 98: commands=( ^------^ SC2034 (warning): commands appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- commands appears unused. Verify u... [1] ludeeus/action-shellcheck@ceeca77f6538
Configuration menu - View commit details
-
Copy full SHA for 091cd75 - Browse repository at this point
Copy the full SHA 091cd75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0362834 - Browse repository at this point
Copy the full SHA 0362834View commit details
Commits on Aug 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6f2d280 - Browse repository at this point
Copy the full SHA 6f2d280View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e975a1 - Browse repository at this point
Copy the full SHA 6e975a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fcb990 - Browse repository at this point
Copy the full SHA 1fcb990View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6e1cc - Browse repository at this point
Copy the full SHA ab6e1ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d9709b - Browse repository at this point
Copy the full SHA 7d9709bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 796252a - Browse repository at this point
Copy the full SHA 796252aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7936c87 - Browse repository at this point
Copy the full SHA 7936c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for b43cd5a - Browse repository at this point
Copy the full SHA b43cd5aView commit details
Commits on Aug 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 833522b - Browse repository at this point
Copy the full SHA 833522bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.