Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt, lint: support icon key for practice exercise config.json #716

Merged
merged 6 commits into from
Dec 15, 2022
Merged

fmt, lint: support icon key for practice exercise config.json #716

merged 6 commits into from
Dec 15, 2022

Commits on Dec 15, 2022

  1. fmt, lint: support icon key for practice exercise 

    The spec previously specified the `icon` key only for a concept
exercise, but a practice exercise config.json file can contain this key
too [1].

[1] exercism/docs@7e4d87703432
    @ErikSchierboom @ee7
    ErikSchierboom authored and ee7 committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    94a96d9 View commit details
    Browse the repository at this point in the history

  2. tests(fmt): test icon for practice exercise

    @ee7
    ee7 committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    59f3571 View commit details
    Browse the repository at this point in the history

  3. tests(sync): test icon for practice exercise

    @ee7
    ee7 committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    499a151 View commit details
    Browse the repository at this point in the history

  4. README, lint, sync, types: make icon key ordering consistent 

    Match the key ordering in the spec.
    @ee7
    ee7 committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a273070 View commit details
    Browse the repository at this point in the history

  5. README: add representer.version 

    We should have added this in c7b14f7.
    @ee7
    ee7 committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    13df6c0 View commit details
    Browse the repository at this point in the history

  6. lint, types_exercise_config: use canonical key ordering

    @ee7
    ee7 committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1c5be58 View commit details
    Browse the repository at this point in the history