config: disable BareExcept warnings #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bump to Nim 1.6.12 caused [1] warnings to appear in the output of `nimble build` and `nimble test`, due to the usage of bare `except` in pkg/jsony and std/unittest. These warnings will be disabled by default in the next Nim release [2], and jsony may resolve the underlying issue [3], but let's disable them explicitly in the meantime. [1] nim-lang/Nim@f01ffbf6f1f6 [2] nim-lang/Nim@69c193e5e2db [3] https://www.github.com/treeform/jsony/pull/58
ErikSchierboom
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bump to Nim 1.6.12 caused warnings to appear in the output of
nimble buildandnimble test, due to the usage of bareexceptin pkg/jsony and std/unittest.These warnings will be disabled by default in the next Nim release, and jsony may resolve the underlying issue, but let's disable them explicitly in the meantime.
Follow-up to #739 (comment).
Without this PR, see the large amount of noise in
nimble test.