-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add linting jobs #307
Comments
@devkabiir Can the CI modify the code in order to do the dart formatting? Or are you just saying to do a formatting check? |
Related #296 Making changes requires an access token for most CI. I'm also not comfortable with any kind of CI to make changes. My proposal is only for linting and checking for formatting. |
Parts of this are touched on in #227 which handles having a workflow or CI. @devkabiir Is there a difference between the two you could make? |
I suppose this one was to add the CI jobs, and the other one was to select the lint rules, other than the default ones enabled by dart analyzer. |
@devkabiir The Test workflow does check the formatting unless you want to refactor the formatting out of the Test workflow and into its own Workflow. Since both workflows are executed when a Dart file or analysis_options.yaml file is changed, then they would always execute on the same PRs. Combining them just reduces our use of GitLab resources. |
No, I don't think separate workflows add any value. However, we should run |
The current CI (GitHub Actions) only runs
configlet
based linting and dart tests. Linting for dart should also be part of the CI.120
characters line width)The text was updated successfully, but these errors were encountered: