Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions.append.md #3812

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Update instructions.append.md #3812

merged 2 commits into from
Nov 4, 2024

Conversation

xanni
Copy link
Contributor

@xanni xanni commented Nov 4, 2024

Clarify that the built-in exponentiation operator ** is equivalent to pow() and therefore doesn't demonstrate an implementation of a square root algorithm, and also note that for the domain of this exercise there are available solutions using only positive integers.

Clarify that the built-in exponentiation operator ** is equivalent to pow() and therefore doesn't demonstrate an implementation of a square root algorithm, and also note that for the domain of this exercise there are available solutions using only positive integers.

This comment was marked as resolved.

@github-actions github-actions bot closed this Nov 4, 2024
@BethanyG BethanyG reopened this Nov 4, 2024
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for this. I made one suggestion. We try to to format our markdown documents so that there is one sentence per line. They are easier to maintain that way, and the markdown engine concatenates them for us.

Other than that, this looks great, so I approved. I'll wait on your change/acceptance to merge it. 😄

Adhere to one sentence per line convention.

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@BethanyG BethanyG merged commit e8b7192 into exercism:main Nov 4, 2024
8 checks passed
@xanni xanni deleted the patch-1 branch November 5, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants