From fc668004c8cc1d2bbe76a139d58ed7bde6637472 Mon Sep 17 00:00:00 2001 From: Tammo Behrends Date: Wed, 15 Mar 2017 12:11:30 +0100 Subject: [PATCH] hello-world: Simplify to unconditional "Hello, World!" As discussed in https://github.com/exercism/x-common/issues/520 closes #430 --- exercises/hello-world/hello_world_test.py | 42 +++-------------------- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/exercises/hello-world/hello_world_test.py b/exercises/hello-world/hello_world_test.py index 7fc4a4cf79..b7b6ec1aec 100644 --- a/exercises/hello-world/hello_world_test.py +++ b/exercises/hello-world/hello_world_test.py @@ -1,48 +1,14 @@ -# -*- coding: utf-8 -*- - -from __future__ import unicode_literals import unittest import hello_world -class HelloWorldTests(unittest.TestCase): - - def test_hello_without_name(self): - self.assertEqual( - 'Hello, World!', - hello_world.hello() - ) - - def test_hello_with_sample_name(self): - self.assertEqual( - 'Hello, Alice!', - hello_world.hello('Alice') - ) +# test cases adapted from `x-common//canonical-data.json` @ version: 1.0.0 - def test_hello_with_other_sample_name(self): - self.assertEqual( - 'Hello, Bob!', - hello_world.hello('Bob') - ) - - def test_hello_with_umlaut_name(self): - self.assertEqual( - 'Hello, Jürgen!', - hello_world.hello('Jürgen') - ) - - def test_hello_with_blank_name(self): - self.assertEqual( - 'Hello, World!', - hello_world.hello('') - ) +class HelloWorldTests(unittest.TestCase): - def test_hello_with_none_name(self): - self.assertEqual( - 'Hello, World!', - hello_world.hello(None) - ) + def test_hello(self): + self.assertEqual('Hello, World!', hello_world.hello()) if __name__ == '__main__':