🤖 Add file patterns to config.json #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently no exemplar and example files, so using the same example file for both.
|
@kotp I'll also need an approval to be able to merge this. Do you have permissions to do so? |
|
And I don't for VimL/Vimscript either. |
|
@kotp You should have permissions now. It does still fail to register your review as an approving review. Could you maybe re-approve? |
|
Checks have failed, so probably now stopped by that. (I do have "close with comment" permissions now though.) |
|
True. Could you reapprove? I can use my superpowers to merge afterwards :) |
kotp
approved these changes
Mar 19, 2021
|
See #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
âš This PR requires you to make a simple change before merging. âš
To save maintainers from having to manually specify the
fileskey in their exercises'.meta/config.jsonfiles, we are providing support for track-level patterns. See this PR for details.This PR adds (purposefully wrong) file patterns to the
config.jsonfile. It is up to you, the track maintainers, to change these patterns to their correct value.You can use the following placeholders:
%{kebab_slug}: thekebab-caseexercise slug (e.g.bit-manipulation)%{snake_slug}: thesnake_caseexercise slug (e.g.bit_manipulation)%{camel_slug}: thecamelCaseexercise slug (e.g.bitManipulation)%{pascal_slug}: thePascalCaseexercise slug (e.g.BitManipulation)We will soon update
configletto enable it to automatically populate the.meta/config.jsonfile'sfilesproperty, at which point we will then batch-PR updates to all tracks that have merged this PR.Tracking
exercism/v3-launch#19