From 16646cfcaafd954ad49be6aa15b96f93022b720f Mon Sep 17 00:00:00 2001 From: TehSphinX Date: Thu, 15 Aug 2019 21:50:08 +0200 Subject: [PATCH 1/3] go/raindrops: missing comments for disapprove --- automated-comments/go/raindrops/entry_signature_changed.md | 4 ++++ automated-comments/go/raindrops/missing_entry_function.md | 1 + 2 files changed, 5 insertions(+) create mode 100644 automated-comments/go/raindrops/entry_signature_changed.md create mode 100644 automated-comments/go/raindrops/missing_entry_function.md diff --git a/automated-comments/go/raindrops/entry_signature_changed.md b/automated-comments/go/raindrops/entry_signature_changed.md new file mode 100644 index 000000000..37b96e8ae --- /dev/null +++ b/automated-comments/go/raindrops/entry_signature_changed.md @@ -0,0 +1,4 @@ +The signature of the `Convert` function should be `Convert(i int) string`. +Exercism is built on the TDD (Test Driven Development) principle. +The tests already exist and define the outward facing interface as well as the behaviour of the code to be implemented. +Changing the signature will break the tests. diff --git a/automated-comments/go/raindrops/missing_entry_function.md b/automated-comments/go/raindrops/missing_entry_function.md new file mode 100644 index 000000000..702dd1a1f --- /dev/null +++ b/automated-comments/go/raindrops/missing_entry_function.md @@ -0,0 +1 @@ +The `Convert` function is missing or couldn't be found. From 22f2d26f373d75736aa0682ebd0c7af4ef44d1d7 Mon Sep 17 00:00:00 2001 From: TehSphinX Date: Sat, 17 Aug 2019 08:52:52 +0200 Subject: [PATCH 2/3] go/raindrops: suggested changes on comments --- automated-comments/go/raindrops/entry_signature_changed.md | 6 +++--- automated-comments/go/raindrops/missing_entry_function.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/automated-comments/go/raindrops/entry_signature_changed.md b/automated-comments/go/raindrops/entry_signature_changed.md index 37b96e8ae..c2d00933c 100644 --- a/automated-comments/go/raindrops/entry_signature_changed.md +++ b/automated-comments/go/raindrops/entry_signature_changed.md @@ -1,4 +1,4 @@ The signature of the `Convert` function should be `Convert(i int) string`. -Exercism is built on the TDD (Test Driven Development) principle. -The tests already exist and define the outward facing interface as well as the behaviour of the code to be implemented. -Changing the signature will break the tests. +Exercism is built on the TDD ([Test Driven Development](http://testfirst.org/about#tdd)) principle. +The tests already exist and define the outward facing interface, as well as the behaviour of the code to be implemented. +Changing the signature breaks the tests. diff --git a/automated-comments/go/raindrops/missing_entry_function.md b/automated-comments/go/raindrops/missing_entry_function.md index 702dd1a1f..930d1cdfd 100644 --- a/automated-comments/go/raindrops/missing_entry_function.md +++ b/automated-comments/go/raindrops/missing_entry_function.md @@ -1 +1 @@ -The `Convert` function is missing or couldn't be found. +Add the function `Convert`, as it is required and currently missing. From 60c16114637ff0a462e86ec1242132294fd095e5 Mon Sep 17 00:00:00 2001 From: Gabriel Nelle Date: Mon, 19 Aug 2019 09:44:47 +0200 Subject: [PATCH 3/3] Update automated-comments/go/raindrops/entry_signature_changed.md Co-Authored-By: Derk-Jan Karrenbeld --- automated-comments/go/raindrops/entry_signature_changed.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automated-comments/go/raindrops/entry_signature_changed.md b/automated-comments/go/raindrops/entry_signature_changed.md index c2d00933c..346700685 100644 --- a/automated-comments/go/raindrops/entry_signature_changed.md +++ b/automated-comments/go/raindrops/entry_signature_changed.md @@ -1,4 +1,4 @@ -The signature of the `Convert` function should be `Convert(i int) string`. +Change the signature of the `Convert` function to be `Convert(i int) string`. Exercism is built on the TDD ([Test Driven Development](http://testfirst.org/about#tdd)) principle. The tests already exist and define the outward facing interface, as well as the behaviour of the code to be implemented. Changing the signature breaks the tests.