Updating saved file names of chat sessions and summary files #15
Conversation
src/AskChatGPTModal.tsx
Outdated
| @@ -42,8 +42,8 @@ export class AskChatGPTModal extends Modal { | |||
| } | |||
|
|
|||
| async saveToAndOpenNewNote(text: string) { | |||
| const noteRandomId = Math.floor(Math.random() * (100000 - 1) + 1); | |||
| const newNote = await this.app.vault.create(`/vaultchat-${noteRandomId}.md`, text) | |||
| const dateTime = (new Date().toDateString()).split(" ").join("-") | |||
There was a problem hiding this comment.
What does this end up looking like? Is it just the date or does it include the time? If it's just the date then you would only be able to save one chat per day without collisions.
There was a problem hiding this comment.
Ran in dev console and got this:
> new Date().toDateString().split(" ").join("-")
< 'Wed-Mar-15-2023'
I think we want something more like Vault Chat - 2023-03-14 09:37:21.md
Hmm, can't have colons in file names in obsidian though... Let's do:
VaultChat-03-14-2023-093721.md where it is VaultChat-<Mon>-<Day>-<Year>-<RandomNumber>.md
src/SummarizeNoteModal.tsx
Outdated
| const summaryTitle = this.fileName.substring(0, this.fileName.length-3) | ||
| const newNote = await this.app.vault.create(`/${summaryTitle} - Vault Chat Summary.md`, text) |
|
Added a change to the callback function for Summarize, per this (feedback)[https://github.com/obsidianmd/obsidian-releases/pull/1752#issuecomment-1469805304]. |
| @@ -1,4 +1,4 @@ | |||
| import { Plugin, TFile} from 'obsidian'; | |||
| import { Editor, MarkdownView, Plugin, TFile} from 'obsidian'; | |||
| if(checking){ | ||
| if(activeFile){ | ||
| return true | ||
| }else{ | ||
| return false | ||
| } | ||
| }else{ | ||
| if(activeFile){ | ||
| const fileName = activeFile.name | ||
| const fileContents = await this.app.vault.read(activeFile) | ||
| new SummarizeNoteModal(this.app, this, this.openAIHandler, fileName, fileContents).open(); | ||
| this.app.vault.read(activeFile).then(f => { new SummarizeNoteModal(this.app, this, this.openAIHandler, fileName, f).open()}) | ||
| return true | ||
| }else{ | ||
| return false | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This could could be simplified for readability:
In general, this sort of code:
if(checking) {
if(activeFile) {
return true
} else {
return false
}
}
Can be simplified to just return the boolean (or return activeFile !== undefined, or whatever makes most sense to you):
if(checking) {
return activeFile!!
}
However, in this case where theres even more conditionals and return statements, the following might make more sense:
checkCallback: (checking: boolean) => {
const activeFile = this.app.workspace.activeEditor?.file
if(activeFile){
if(!checking){
const fileName = activeFile.name
this.app.vault.read(activeFile).then(f => { new SummarizeNoteModal(this.app, this, this.openAIHandler, fileName, f).open()})
}
return true
}
return false
}
This updates the file names of the Summarize and the Ask commands!