Bugfix initializing DocBin with attributes #4368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We called
intify_attrs()
with a list instead of with a dictionary when creating a newDocBin
. I created a small methodintify_attr()
that takes just one string argument to apply it quickly on lists.I also added the example from the docs to the unit tests, and fixed a typo in the example.
Fixes #4367
Types of change
bug fix + documentation fix
Checklist