Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-linear-gradient] Add proper children prop declaration #10227

Merged
merged 3 commits into from
Sep 18, 2020
Merged

[expo-linear-gradient] Add proper children prop declaration #10227

merged 3 commits into from
Sep 18, 2020

Conversation

sjchmiela
Copy link
Contributor

Why

We allow children property on LinearGradient in code, but no in type.

How

Wrapped props with React.PropsWithChildren.

Test Plan

TS compiled the library, no longer reported problems in NCL.

@sjchmiela sjchmiela requested a review from bbarthec September 18, 2020 09:48
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@sjchmiela sjchmiela merged commit 7db65de into master Sep 18, 2020
@sjchmiela sjchmiela deleted the @sjchmiela/add-linear-gradient-children branch September 18, 2020 13:50
@tylerc tylerc mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarthec bbarthec bbarthec approved these changes

@brentvatne brentvatne Awaiting requested review from brentvatne brentvatne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjchmiela @bbarthec