[notifications] add 'assert' as a dependency #11171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruzach
changed the title
|
Native Component List for this branch is ready |
sjchmiela
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
I wonder why I haven't gotten it while trying expo-notifications out in NCL… Could it be because jest-expo-puppeteer transiently depends on assert?
Since you've tested this change and it worked as expected in NCL which used assert too — thank you for taking care of this and sorry for not catching that earlier! 🥇
|
@sjchmiela - yeah it's hard to catch missing dependency issues within the expo/expo monorepo because as long as any other package in the repo includes the dep then it'll be resolved 😱 |
brentvatne
pushed a commit
that referenced
this pull request
Nov 30, 2020
byCedric
pushed a commit
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Without this dependency, SDK 40 projects will fail after starting the bundler with:
How
yarn add assertTest Plan
yarn add local/path/to/expo-notifications && expo publishsucceeds