-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[localization] Add currency, separators, isMetric and update region #11663
Conversation
e87d9c0
to
df45696
Compare
df45696
to
121ba04
Compare
friendly ping to @bbarthec :) |
e8953e2
to
10878be
Compare
packages/expo-localization/src/__tests__/Localization-test.native.ts
Outdated
Show resolved
Hide resolved
packages/expo-localization/src/__tests__/Localization-test.native.ts
Outdated
Show resolved
Hide resolved
packages/expo-localization/src/__tests__/Localization-test.web.ts
Outdated
Show resolved
Hide resolved
packages/expo-localization/src/__tests__/Localization-test.web.ts
Outdated
Show resolved
Hide resolved
Sounds good. I've made the suggested changes, thank you for reviewing. |
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
…ive.ts Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
…ive.ts Co-authored-by: James Ide <ide@users.noreply.github.com>
f70cff6
to
fbb7d28
Compare
Co-authored-by: James Ide <ide@users.noreply.github.com>
@IjzerenHein hi, this probably not the right place to ask, but could you please add is24Hour format property? Thank you! |
@chybisov This PR already been merged. If you want that feature added, please create a PR or request the feature on https://expo.canny.io/ |
Why
Adds the
region
property for Android and 4 new properties:currency
,decimalSeparator
,groupingSeparator
andisMetric
.Replaces and closes #10354
How
region
property for Androidcurrency
property for iOS and AndroiddecimalSeparator
property for iOS, Android and webgroupingSeparator
property for iOS, Android and webisMetric
property for iOS, Android and webregion
property on web when locale contained variants or both region and scriptTest Plan