Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blur] Fix types - tint now a string union 'dark' | 'light' | 'default' rather than any string #12264

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

brentvatne
Copy link
Member

Why

See: https://snack.expo.io/@brents/basic-blurview-usage

Notice that tint is not properly validated. Part of the problem is described in ENG-656.

How

Get rid of BlurView.d.ts and use the iOS component as the canonical version.

Test Plan

Make these changes in a local project using expo-blur and see that validations work as expected.

Checklist

  • [n/a] Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).
  • [n/a] This diff will work correctly for expo build (eg: updated @expo/xdl).
  • [n/a] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@brentvatne brentvatne requested a review from tsapeta as a code owner March 19, 2021 19:42
@brentvatne brentvatne changed the title [blur] Fix types - tint now a string union 'dark' | 'light' | 'default' rather than any string [blur] Fix types - tint now a string union 'dark' | 'light' | 'default' rather than any string Mar 19, 2021
@brentvatne brentvatne merged commit 70c7f57 into master Mar 19, 2021
@brentvatne brentvatne deleted the @brent/fix-expo-blur-types branch March 19, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant