Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][android] Update react-native-svg to 12.1.1 #13154

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Conversation

brentvatne
Copy link
Member

Why

SDK 42

How

  • The latest version of react-native-svg moves the ios source code to the apple directory within their repo, which is easy enough to adjust, but the reason for the change was to add macOS support. This required writing a SvgModifier in our vendoring script to delete macOS specific source files and add a missing header import.
  • The commit bumping the version to 12.1.1 was not actually pushed to the react-native-svg repo, so I had to import from the parent commit and then manually increment the version number in our repo from 12.1.0 to 12.1.1.

Test Plan

Built iOS and Android Expo Go, ran NCL on unversioned.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@brentvatne brentvatne requested review from ide and tsapeta as code owners June 4, 2021 01:58
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 4, 2021
@tsapeta tsapeta merged commit 5d61ab6 into master Jun 4, 2021
@tsapeta tsapeta deleted the @brent/update-svg branch June 4, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants