[constants] Fix build phase error in xcode for nodejs possibly not found in nvm

[Kudo]

Why

if user does not install nodejs by homebrew but something like nvm or volta. typically these will setup shell $PATH. however, building in xcode does not honor login shell rc file and getting errors for nodejs not found.

How

execute the script with bash -l that will honor login shell settings.

Test Plan

pass building bare-expo and expo-go in xcode.

Checklist

• Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).

[brentvatne]

if node isn't set up to work without the login shell, i imagine builds won't work anyways, right? because react-native's bundle script will fail. that said, this seems reasonable in order to avoid being the cause of the failure.

[Kudo]

if node isn't set up to work without the login shell, i imagine builds won't work anyways, right? because react-native's bundle script will fail. that said, this seems reasonable in order to avoid being the cause of the failure.

exactly. react-native expects to setup $NODE_BINARY in react-native-xcode.sh and will show error if node not found. however, in codegen script, there is also a bash -l -c. i would say the bash -c -l strategy isn't a 100% working solution but may reduce failure rate and no hurt to do so.