[linear-gradient][ios] Rewrite entire module to Swift #15168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com>
tsapeta
force-pushed
the
@tsapeta/ios/rewrite-linear-gradient
branch
from
debbba4 to
513a2e1
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
lukmccall
approved these changes
Nov 15, 2021
|
|
||
| if let gradient = CGGradient(colorsSpace: colorSpace, colors: colors as CFArray, locations: locations) { | ||
| let size = bounds.size | ||
|
|
There was a problem hiding this comment.
Suggested change
You don't have to remove that line, but it looks odd to me 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Previously only the module has been rewritten to Swift. Also we kept the legacy Objective-C implementation for one SDK cycle, so it can be removed now.
How
EXLinearGradienttoExpoLinearGradient— following inExpoModulesCoreandExpoSystemUIfootstepsunimodule.json(expo-module.config.jsonexists)Intin "colors" prop replaced withCGColorCGPointDoublereplaced withCGFloatNSNullparsed from JSON is not properly bridged to Swift'snil, so I fixedfromNSObjectfunctionstart,end,locationspropsTest Plan
NCL screen for LinearGradient seems to work as expected