Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade react-native-reanimated to 2.3.1 #15574

Merged
merged 5 commits into from
Dec 15, 2021

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Dec 15, 2021

Why

upgrade react-native-reanimated to 2.3.1 for sdk 44 release

How

  • et uvm -m react-native-reanimated -c "2.3.1"
  • revert reanimated autolinking exclusion for bare-expo and bare-sandbox
  • et add-sdk -p ios -s 44.0.0 -v react-native-reanimated
  • et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0 and pick reanimated changes.

Test Plan

android versioned expo go + gesture handler NCL
ios versioned expo go + gesture handler NCL

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Dec 15, 2021
@Kudo Kudo requested a review from brentvatne December 15, 2021 09:14
@Kudo Kudo marked this pull request as ready for review December 15, 2021 09:15
@Kudo Kudo requested review from ide and tsapeta as code owners December 15, 2021 09:15
@Kudo Kudo removed request for ide and tsapeta December 15, 2021 09:15
@Kudo
Copy link
Contributor Author

Kudo commented Dec 15, 2021

this pr does not introduce many native changes. for sdk 44 release, i'm going to merge this pr and have a post-review.

@Kudo Kudo merged commit f1adcf5 into master Dec 15, 2021
@Kudo Kudo deleted the @kudo/sdk44/upgrade-reanimated branch December 15, 2021 09:16
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading it! 👍

Kudo added a commit that referenced this pull request Dec 15, 2021
# Why

upgrade react-native-reanimated to 2.3.1 for sdk 44 release

# How

- `et uvm -m react-native-reanimated -c "2.3.1"`
- revert reanimated autolinking exclusion for bare-expo and bare-sandbox
- `et add-sdk -p ios -s 44.0.0 -v react-native-reanimated`
- `et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0` and pick reanimated changes.

# Test Plan

android versioned expo go + gesture handler NCL
ios versioned expo go + gesture handler NCL
DominickVale pushed a commit to DominickVale/expo that referenced this pull request Dec 15, 2021
# Why

upgrade react-native-reanimated to 2.3.1 for sdk 44 release

# How

- `et uvm -m react-native-reanimated -c "2.3.1"`
- revert reanimated autolinking exclusion for bare-expo and bare-sandbox
- `et add-sdk -p ios -s 44.0.0 -v react-native-reanimated`
- `et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0` and pick reanimated changes.

# Test Plan

android versioned expo go + gesture handler NCL
ios versioned expo go + gesture handler NCL
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
# Why

upgrade react-native-reanimated to 2.3.1 for sdk 44 release

# How

- `et uvm -m react-native-reanimated -c "2.3.1"`
- revert reanimated autolinking exclusion for bare-expo and bare-sandbox
- `et add-sdk -p ios -s 44.0.0 -v react-native-reanimated`
- `et remove-sdk -p android -s 44.0.0 && et add-sdk -p android -s 44.0.0` and pick reanimated changes.

# Test Plan

android versioned expo go + gesture handler NCL
ios versioned expo go + gesture handler NCL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants