[expo] Upgrade react-native-maps to 0.24.2

[sjchmiela]

Just a regular dependency update. 🙂

[mczernek]

Don't we want to use community version? Are you sure that using our fork is still needed?

[sjchmiela]

I updated our fork to match the community master, so now the only difference is:

react-native-maps/react-native-maps@master...expo:master

[mczernek]

Yeah, that's why i think we might migrate to community repo - it will require less work to update in the future. But that's just suggestion :)

[sjchmiela]

It's the question of whether we want to maintain our fork by git pull --rebaseing every time we want to update the library or whether we want to add a new preprocessor declaration to our build process. Last time we discussed, @tsapeta and I have settled on maintaining the fork. @tsapeta, what do you think now?

[mczernek]

It's the question of whether we want to maintain our fork by git pull --rebaseing every time we want to update the library or whether we want to add a new preprocessor declaration to our build process. Last time we discussed, @tsapeta and I have settled on maintaining the fork. @tsapeta, what do you think now?

My suggestion is to go with declaring exact commit (tag) as a parameter of gulp task, which might be overriden by --commit argument. This way we still keep track of used version, prevent ourselves from accidental updates but do not need to have fork when it's not required. What do you think?

[tsapeta]

I agree that if the fork is not really required, then it would be better to just use the community repo. I don't remember why I removed HAVE_GOOGLE_MAPS flag, but maybe it is worth to check whether we still need it.

[sjchmiela]

All the Google Maps classes declarations are ifdef wrapped with this macro, so with this flagged undefined we don't get any react-native-maps Google Maps classes. We have to either define it or remove the macros. 🙂

[sjchmiela]

x-ref expo/expo-cli#601