Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camera][web] Better browser support #6207

Merged
merged 18 commits into from
Nov 11, 2019
Merged

[camera][web] Better browser support #6207

merged 18 commits into from
Nov 11, 2019

Conversation

EvanBacon
Copy link
Contributor

Why

Camera is flakey across many mobile browser. Documentation for web was lacking.

How

  • Fix camera flipping on Android and iOS
  • Added methods for getting available cameras
  • Added method for getting camera availability
  • Fix unmounting on Android Chrome
  • Fix Android zooming

Test Plan

  • Physical testing required: Open NCL to camera and try zooming, torch, flipping

@EvanBacon EvanBacon added Platform: web Using Expo in the browser Camera labels Nov 7, 2019
@EvanBacon EvanBacon requested a review from brentvatne November 7, 2019 23:15
@EvanBacon EvanBacon requested a review from bbarthec as a code owner November 7, 2019 23:15
@EvanBacon EvanBacon self-assigned this Nov 7, 2019
bbarthec
bbarthec reviewed Nov 8, 2019
View reviewed changes
docs/pages/versions/unversioned/sdk/camera.md Outdated Show resolved Hide resolved
docs/pages/versions/unversioned/sdk/camera.md Outdated Show resolved Hide resolved
packages/expo-camera/src/ExponentCamera.web.tsx Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/UserMediaManager.ts Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/CameraModule.ts Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/UserMediaManager.ts Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/UserMediaManager.ts Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/UserMediaManager.ts Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/UserMediaManager.ts Outdated Show resolved Hide resolved
packages/expo-camera/src/CameraModule/UserMediaManager.ts Outdated Show resolved Hide resolved
@EvanBacon EvanBacon merged commit dbac7fd into master Nov 11, 2019
@EvanBacon EvanBacon deleted the @evanbacon/expo-camera/better-support branch November 11, 2019 22:17
@EvanBacon EvanBacon mentioned this pull request Aug 11, 2020
Closed
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
@EvanBacon
[camera][web] Better browser support (expo#6207)
9523a6c 
* Add web support section to the docs

* Created RNWeb video element

- muted audio by default
- possibly corrected camera mirroring

* Added isAvailableAsync for web

- Fixed video stopping
- Added MS Media

* Fixed safari camera flipping bug

* Added getAvailableCameraTypesAsync

* lint fix

* Removed console log

* Update docs/pages/versions/unversioned/sdk/camera.md

Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com>

* Update docs/pages/versions/unversioned/sdk/camera.md

Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com>

* Fixed chrome types

* Update Camera.d.ts

* updated build

* fix lint

* updated module build file

* updated TS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarthec bbarthec bbarthec left review comments

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees

@EvanBacon EvanBacon

Labels
Camera Platform: web Using Expo in the browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @bbarthec