[expo-secure-store] Fix keychainAccessible behavior #6291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 🎉 Did you test setting the value on a device with the passcode enabled, then disabling the passcode, and making sure |
|
Exactly! |
cruzach
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #5561.
How
Debugging step-by-step I saw that value for
keychainAccessiblekey in theoptionsmap is3and still we try to run it throughconstantsToExportlookup.Test Plan
I have confirmed that with this fix applied getting the value right after setting it on a passcode-disabled device always returns
nulland getting the value after setting it on a passcode-enabled device returns the value.