[expo-camera] Save metadata #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
suggested changes
Dec 5, 2019
bbarthec
approved these changes
Dec 9, 2019
lukmccall
force-pushed
the
@lukmccall/expo-camera-fix-metadata
branch
from
4d07d49 to
850106f
Compare
bbarthec
reviewed
Dec 16, 2019
Comment on lines
+8
to
+10
|
|
||
| import androidx.exifinterface.media.ExifInterface; | ||
|
|
There was a problem hiding this comment.
Maybe just move import androidx.exifinterface.media.ExifInterface; below import android.* section 🤔
tsapeta
approved these changes
Dec 16, 2019
tsapeta
force-pushed
the
@lukmccall/expo-camera-fix-metadata
branch
from
850106f to
1748832
Compare
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why Resolves expo#6399. # How UIImage strips metadata (https://stackoverflow.com/a/25595495). So I've added it manually using `Image IO API`. Moreover, I've also deleted `updateImageSampleMetadata` function - it was unuse. Android bitmap also strips metadata. # TODO - [x] iOS - [x] Android # Test Plan - https://snack.expo.io/@lukaszkosmaty/github---camera---fix-metadata ✅(returns correct metadata) - NCL ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #6399.
How
UIImage strips metadata (https://stackoverflow.com/a/25595495). So I've added it manually using
Image IO API. Moreover, I've also deletedupdateImageSampleMetadatafunction - it was unuse.Android bitmap also strips metadata.
TODO
Test Plan