[expo-contacts] Fix presentFormAsync pre-filling #7285
Merged
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
approved these changes
Mar 6, 2020
| public String getDisplayName() { | ||
| if (displayName == null) { | ||
| if (firstName != null) { | ||
| if (lastName != null) { |
There was a problem hiding this comment.
Too many ifs 😅 Maybe we can make it simpler? Also, what if firstName == null? Shouldn't we return lastName then?
There was a problem hiding this comment.
I made it simpler ;)
We shouldn't return only lastName, cause then Android will interpret this value as a first name.
lukmccall
force-pushed
the
@lukmccall/expo-contacts-fix-presentFormAsync
branch
from
9a43090 to
aff9b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #6401.
How
See the original PR. Some of the issues were fixed in SDK 35. However, we still need to fix some of them.
Test Plan