Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-native-svg to 12.1.0 #8491

Merged
merged 2 commits into from
May 26, 2020
Merged

Update react-native-svg to 12.1.0 #8491

merged 2 commits into from
May 26, 2020

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented May 26, 2020

Why

Upgrade 3rd party lib for SDK38

How

Ran et update-module -m react-native-svg -c ffa2e69c17ce02b21f393a5b57cdbef1c039fe3d.

Test Plan

Tested NCL on Android and iOS.

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@tsapeta tsapeta marked this pull request as ready for review May 26, 2020 16:33
@tsapeta tsapeta requested a review from ide as a code owner May 26, 2020 16:33
@tsapeta tsapeta requested a review from brentvatne May 26, 2020 16:46
@tsapeta tsapeta merged commit d43b6ed into master May 26, 2020
@tsapeta tsapeta deleted the @tsapeta/update-svg branch May 26, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esamelson esamelson esamelson approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsapeta @esamelson