[local-authentication] Fix crash when NSFaceIDUsageDescription is not provided and device fallback is disabled
#8595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
tsapeta
commented
Jun 1, 2020
lukmccall
approved these changes
Jun 1, 2020
tsapeta
added a commit
that referenced
this pull request
Jun 1, 2020
…ot provided and device fallback is disabled (#8595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
During QA I encountered that our
expo-local-authenticationexample innative-component-listcrashes whenNSFaceIDUsageDescriptionis not provided inInfo.plistanddisableDeviceFallbackis set totrue. It was probably introduced by #8219.How
If device fallback is disabled and
NSFaceIDUsageDescriptionis not specified then automatically resolve with no success and appropriate error code and warning message. Also refactored the example a little bit so it's easier to test and supports both types of authentication (with and without device fallback).Test Plan
Tested on NCL ✅