Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admob] Added isAvailableAsync #9690

Merged
merged 3 commits into from
Aug 12, 2020
Merged

[admob] Added isAvailableAsync #9690

merged 3 commits into from
Aug 12, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 11, 2020 •
edited
Loading

Why

How

@EvanBacon EvanBacon added Admob enhancement New feature or request labels Aug 11, 2020
@EvanBacon EvanBacon requested a review from sjchmiela as a code owner August 11, 2020 23:12
@EvanBacon EvanBacon self-assigned this Aug 11, 2020
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

sjchmiela
sjchmiela approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the test screen, apart from that looks great to me! 🏅

docs/pages/versions/unversioned/sdk/admob.md
- Here is the full list of Test IDs
- [iOS Test IDs](https://developers.google.com/admob/ios/test-ads)
- [Android Test IDs](https://developers.google.com/admob/android/test-ads)
- Ensure you **never** load a real production ad in an Android Emulator or iOS Simulator. Failure to do this can result in a ban from the AdMob program.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't know that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha me either, until pillar valley got put on review. I downloaded the APK and dropped it in the emulator to test if turtle builds added the android package as a URI scheme for production Android apps -- I didn't have my Android phone on me at the time.

Got one of these a few hours later:

Screen Shot 2020-08-12 at 2 46 56 PM

I pushed a fix, then about a week later ads started showing up again -- no follow up email though.

apps/native-component-list/src/screens/AdMobScreen.tsx Show resolved Hide resolved
@EvanBacon EvanBacon merged commit 6d905a8 into master Aug 12, 2020
@EvanBacon EvanBacon deleted the @evanbacon/ads-admob/isavailableasync branch August 12, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjchmiela sjchmiela sjchmiela approved these changes

Assignees

@EvanBacon EvanBacon

Labels
Admob enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[expo-ads-admob] Create isAvailableAsync method
2 participants
@EvanBacon @sjchmiela