Better throwing. fully automatic #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This throwing position has a higher success rate from my testing and link can restart the bowling game on his own if he doesn't get a strike.
|
Do keep in mind if Link doesn't get a strike it takes a minute before link can get back into the loop. but as this is intended to run over a long time with being touched I felt it didn't matter too much. |
|
This sounds really cool! Thanks 🙇 I'll give this a try 😄 |
|
The bailing on fail works nicely. 😎 However, for me, the new throw seems to fail more often than not. I get around 20% success rate. Majority of throws will leave one pin standing. What kind of success rate were you seeing with this throw? Nevertheless, merging, but converting back to the throw that worked better for me. Cheers! 🍻 |
exsilium
pushed a commit
that referenced
this pull request
Nov 29, 2017
Structure, Velocity, Fail Gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified Joycon.c and managed to make it completely automatic. Even if it isn't a strike link is able to start the bowling game over without any issues. I also modified where link throws the snowball. So far it has had a much higher success rate.