Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced location handling #87

Closed
wants to merge 22 commits into from
Closed

Enhanced location handling #87

wants to merge 22 commits into from

Conversation

bdunogier
Copy link
Member

@bdunogier bdunogier commented Oct 7, 2020 •
edited
Loading

  • change the main item in use to Location instead of Content
  • apply tree root settings

TODO

  • Update collection resolver to return locations as well
  • In multi-location + multi-site cases, check that _location and _url refer to the relevant location
  • Handle root location prefix when loading by urlAlias (See UrlAliasRouter)
  • Handle root location prefix when generating URL aliases

@bdunogier bdunogier changed the title Better location handling Enhanced location handling Oct 15, 2020
Bertrand Dunogier added 15 commits October 15, 2020 17:52
Implemented a LocationGuesser
bc0f6bc 
Based on a content item, returns the "right" location for it.

For now, returns a location within the current tree root.
Drafted change to location collections instead of content
a004f16
Added research doc
a50a61b
CS fix
6c57194
Remove tree_root prefix from url aliases
7c3b8d9
fixup! Implemented a LocationGuesser
cd28d8e
fixup! Drafted change to location collections instead of content
28b5fda
fixup! Remove tree_root prefix from url aliases
6018413
fixup! Drafted change to location collections instead of content
001c56d
Renamed DomainContent to Item (ArticleContent -> ArticleItem
cd06554 
Also uses a custom Value\Item, a combination of a Content and Location.
Load location by urlAlias with handling of tree_root
67433d2
Renamed 'id' argument to 'contentId'
fe5668f
Added locationRemoteId argument for item loading
eb0c7aa
fixup! Renamed DomainContent to Item (ArticleContent -> ArticleItem
ef6841a
Made items collections return items as well
4317f51
@bdunogier bdunogier force-pushed the better_location_handling branch from da6ad18 to 6a6b223 Compare November 19, 2020 16:11
@bdunogier bdunogier force-pushed the better_location_handling branch from 6a6b223 to 84392e6 Compare November 24, 2020 13:26
@bdunogier
Copy link
Member Author

Replaced by #90.

@bdunogier bdunogier closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdunogier