Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add screenshot feature #1391

Merged
merged 25 commits into from
May 14, 2024
Merged

add screenshot feature #1391

merged 25 commits into from
May 14, 2024

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Apr 24, 2024

Screenshot interaction feature as per #1194. Draft PR mostly because I'm not sure how to go about the testing.

@snoyer snoyer marked this pull request as ready for review April 25, 2024 13:01
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 96.57%. Comparing base (f0a3730) to head (d20b440).
Report is 6 commits behind head on master.

Files Patch % Lines
application/F3DStarter.cxx 97.60% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
+ Coverage   96.55%   96.57%   +0.01%     
==========================================
  Files         103      103              
  Lines        7555     7679     +124     
==========================================
+ Hits         7295     7416     +121     
- Misses        260      263       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snoyer snoyer force-pushed the screenshot branch 2 times, most recently from b1ddaf7 to 7cd8e6a Compare April 29, 2024 05:27
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a doc update

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed. Improving the doc would also be nice and help with the release notes :)

application/F3DOptionsParser.cxx Outdated Show resolved Hide resolved
application/F3DStarter.cxx Show resolved Hide resolved
application/F3DStarter.cxx Outdated Show resolved Hide resolved
doc/user/INTERACTIONS.md Outdated Show resolved Hide resolved
doc/user/INTERACTIONS.md Outdated Show resolved Hide resolved
doc/user/OPTIONS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

doc/user/OPTIONS.md Outdated Show resolved Hide resolved
doc/user/OPTIONS.md Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk May 14, 2024 12:00
@mwestphal mwestphal merged commit 34f0afa into f3d-app:master May 14, 2024
41 checks passed
@snoyer snoyer deleted the screenshot branch May 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants