Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Change syntax and updates all configs #1730

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Nov 25, 2024

Change config file syntax to:

[
{
  "options": 
  {
    "filename": true,
    "camera-direction": "-1,-0.5,-1",
    "hdri-ambient": true,
    "translucency-support": true,
    "animation-progress": true
  }
},
{
  "match": ".*obj",
  "options": 
  {
    "axis": true,
    "tone-mapping": true
  }
}
]

also adds a test and updates doc

Later:

Add config file control for interactions: #1740
Add glob support in config files: Create issue
Add complete interaction doc: Another PR
Add command-script option: #1734
Reenable test with command script: Another PR

@mwestphal mwestphal changed the title [draft] Change config file syntax Config: Change syntax and updates all configs Nov 27, 2024
@mwestphal mwestphal requested a review from Meakk November 27, 2024 08:00
Copy link
Contributor

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (f3d7627) to head (8d95329).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
- Coverage   96.97%   95.70%   -1.28%     
==========================================
  Files         110      118       +8     
  Lines        8872     9335     +463     
==========================================
+ Hits         8604     8934     +330     
- Misses        268      401     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal merged commit c3eb2e1 into f3d-app:master Nov 28, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants