-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Change syntax and updates all configs #1730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
force-pushed
the
modify_config_files
branch
from
November 27, 2024 07:47
6cd54d2
to
a0bbd94
Compare
mwestphal
changed the title
[draft] Change config file syntax
Config: Change syntax and updates all configs
Nov 27, 2024
Meakk
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
snoyer
reviewed
Nov 27, 2024
snoyer
reviewed
Nov 27, 2024
mwestphal
force-pushed
the
modify_config_files
branch
from
November 28, 2024 06:30
c634bc7
to
e8ffeb4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
- Coverage 96.97% 95.70% -1.28%
==========================================
Files 110 118 +8
Lines 8872 9335 +463
==========================================
+ Hits 8604 8934 +330
- Misses 268 401 +133 ☔ View full report in Codecov by Sentry. |
mwestphal
force-pushed
the
modify_config_files
branch
from
November 28, 2024 07:45
17abdb0
to
a8ebfd8
Compare
snoyer
reviewed
Nov 28, 2024
Meakk
reviewed
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change config file syntax to:
also adds a test and updates doc
Later:
Add config file control for interactions: #1740
Add glob support in config files: Create issue
Add complete interaction doc: Another PR
Add command-script option: #1734
Reenable test with command script: Another PR