Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tissue oxygen saturation St02 as a valid dataTypeLabel #145

Merged
merged 2 commits into from
May 29, 2024

Conversation

rob-luke
Copy link
Member

Closes #125

@samuelpowell
Copy link
Collaborator

@rob-luke so will this automatically pass in the validator now it is in the MD?

@rob-luke
Copy link
Member Author

Correct, or at least it should! We would probably want to add a test to the validator to ensure this is the case.

I also think it's ok if the spec leads the validator between version releases. I see a reasonable workflow as...

  1. update made to spec and merged to main
  2. tests added to validator to ensure it the new spec changes work with validator, changes made to validator if required
  3. updated validator version released
  4. updated spec version released

Within the governance model we have set up, the maintainers would do the merging in step 1, complete step 2 and 3, and then after the board and maintainers jointly agree on new spec version, the maintainers release a new spec. However, for now the board and maintainers are us, so we should remember to update the validator, thanks for highlighting this.

@samuelpowell
Copy link
Collaborator

Yes, this makes sense

@rob-luke rob-luke merged commit 227d9e3 into fNIRS:master May 29, 2024
3 checks passed
@rob-luke rob-luke deleted the st02 branch May 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting NIRO-200NX data to snirf
3 participants