Do not export empty translation on Android

[ferrandp]

Android can handle when a translation is missing, but if the translation is empty Android will display an empty string, which is not what we want.

[jvigne]

With a method has_value? in the Translation entity and another one has_translations? in TranslationGroupViewModel you can refactor the code like this :

# translation.rb
def has_value?
  value.present?
end

# translation_group_view_model.rb
def has_translations?
  translation_view_models.present?
end

# strings_serializer.rb
def map_singulars(translations:)
  translations.select(&:has_value?).map { |translation| @translation_mapper.map(translation: translation) }
end

def map_plurals(plurals:)
  plurals
    .select(&:has_value?)
    .map { |label, translations| @translation_group_mapper.map(label: label, translations: translations) }
    .select(&:has_translations?)
end

Otherwise you can also write it like this

def map_singulars(translations:)
  translations
    .select { |translation| translation.value.present? }
    .map { |translation| @translation_mapper.map(translation: translation) }
end

def map_plurals(plurals:)
  plurals
    .select { |translation| translation.value.present? }
    .map { |label, translations| @translation_group_mapper.map(label: label, translations: translations) }
    .select { |translation| translation.translation_view_models.present? }
end

[jvigne]

Just one more change : .any? { |translation| translation.value.present? } => .any?(&:has_value?)

[ferrandp]

Those are translation ViewModels, not translations so they have no has_value method. I did not know if it makes sense to add such a method for a ViewModel. What do you think ?

[jvigne]

Good point, you are right. In that case we can add an has_value (boolean) attribute in TranslationViewModel here and set it in the mapper here using the has_value? method. We would have any?(&:has_value). What do you think of this option ?

[jvigne]

One more change and we are good

[jvigne]

Thank you for this PR