Make (re)validateOn overridable per field #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for modularforms failed.
|
|
Thanks for the PR! Your implementation looks good at first glance. I plan to release a new version in the next few days and include this change if I don't find any problems. |
XiNiHa
force-pushed
the
feat/validateon-per-field
branch
from
d6d77d3 to
1bd5945
Compare
|
A new version is available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
(re)validateOncould only be set at the top of the form. However, in some cases, it'd be desirable to override this behavior (mostly because some fields already fulfill the validation from the start), so I made one.I've thought about the implementation of
setValuesbut left it as-is for now.If the Solid implementation gets approved, I'll also implement it for others.Done!