Add support for Result.isOk and Result.isError for Javascript/Typescript #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zprobinson Thank you for your contribution, looks good! |
ncave
approved these changes
Jan 31, 2024
By all means, contributions are always welcome, and no contribution is too small. It should be pretty easy to add support for Python/Rust/Dart targets too, it's more or less the same. |
MangelMaxime
force-pushed
the
resultToBoolean
branch
from
4136c3b to
a4a9376
Compare
|
Thank @zprobinson If you want to add support for others target too, please do so :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #3726
First time contributor, I'm willing to learn whatever you have to share.
I'm curious why it seems the static functions for Result seem light. Is it intentional, or would you be interested in expanding to the rest of the module?
Additionally unsure of how I handled the Replacements.fs file. That's a scary file to look at, let me know if there is some more intuition that I was missing on my first pass.
Only includes JS/TS support. Others can be added if this is okay.