From 86ba3477c9b89d497fb4fe7388aaa3928bd0dd20 Mon Sep 17 00:00:00 2001 From: Maxime Mangel Date: Thu, 26 Sep 2024 21:57:44 +0200 Subject: [PATCH 1/2] [Python] Fix nuget packages with hypens in their names Fix #3875 --- src/Fable.Compiler/ProjectCracker.fs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Fable.Compiler/ProjectCracker.fs b/src/Fable.Compiler/ProjectCracker.fs index 9df085d27..2eb21e243 100644 --- a/src/Fable.Compiler/ProjectCracker.fs +++ b/src/Fable.Compiler/ProjectCracker.fs @@ -732,7 +732,7 @@ let copyFableLibraryAndPackageSourcesPy (opts: CrackerOptions) (pkgs: FablePacka | _ -> let name = Naming.applyCaseRule Core.CaseRules.SnakeCase pkg.Id - IO.Path.Combine(opts.FableModulesDir, name.Replace(".", "_")) + IO.Path.Combine(opts.FableModulesDir, name.Replace(".", "_").Replace("-", "_")) copyDirIfDoesNotExist false sourceDir targetDir From af215e54134f5b7369e19fc9fd36481830f75fdd Mon Sep 17 00:00:00 2001 From: Maxime Mangel Date: Thu, 26 Sep 2024 22:03:08 +0200 Subject: [PATCH 2/2] chore: add changelog entries --- src/Fable.Cli/CHANGELOG.md | 4 ++++ src/Fable.Compiler/CHANGELOG.md | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/Fable.Cli/CHANGELOG.md b/src/Fable.Cli/CHANGELOG.md index 6aeec23df..ac3912d10 100644 --- a/src/Fable.Cli/CHANGELOG.md +++ b/src/Fable.Cli/CHANGELOG.md @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 * [Rust] Updated support for interface object expressions (by @ncave) * [Rust] Added missing ResizeArray methods and tests (by @ncave) +### Fixed + +* [GH-3900](https://github.com/fable-compiler/Fable/pull/3900) [Python] Fix nuget packages with hypens in their names (by @MangelMaxime) + ## 4.21.0 - 2024-09-19 ### Added diff --git a/src/Fable.Compiler/CHANGELOG.md b/src/Fable.Compiler/CHANGELOG.md index faf330449..77a5c1380 100644 --- a/src/Fable.Compiler/CHANGELOG.md +++ b/src/Fable.Compiler/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +### Fixed + +* [GH-3900](https://github.com/fable-compiler/Fable/pull/3900) [Python] Fix nuget packages with hypens in their names (by @MangelMaxime) + ## 4.0.0-alpha-013 - 2024-09-19 ### Changed