Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boolean comparison for healthy option #1279

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Fix Boolean comparison for healthy option #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6591692
Fix Boolean comparison for healthy
Oct 14, 2019
1bfabe2
Update changelog with healthy option fix #1279
Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Allow merging of image configurations using <imagesMap> ([#360](https://github.com/fabric8io/docker-maven-plugin/issues/360))
- Treat bridged and default network mode the same #1234
- Fix NPE when cacheFrom is missing from config #1274
- Fix healthy option regression introduced in 0.25.0 #1279

* **0.31.0** (2019-08-10)
- Fix test cases on Windows ([#1220](https://github.com/fabric8io/docker-maven-plugin/issues/1220))
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/fabric8/maven/docker/service/WaitService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private List<WaitChecker> prepareWaitCheckers(ImageConfiguration imageConfig, Pr
}
}

if (wait.getHealthy() == Boolean.TRUE) {
if (Boolean.TRUE.equals(wait.getHealthy())) {
checkers.add(new HealthCheckChecker(dockerAccess, containerId, imageConfig.getDescription(), log));
}

Expand Down