Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add killafter parameter to image:run:wait #294

Merged
merged 1 commit into from
Sep 23, 2015
Merged

add killafter parameter to image:run:wait #294

merged 1 commit into from
Sep 23, 2015

Conversation

fiji-flo
Copy link
Contributor

Sets the delay between docker stop and kill. This resolves #293
Signed-off-by: Florian Merz florian.merz@goeuro.com

add killafter parameter to image:run:wait
382e389 
this sets the delay between docker stop and kill

Signed-off-by: Florian Merz <florian.merz@goeuro.com>
@rhuss rhuss merged commit 382e389 into fabric8io:integration Sep 23, 2015
@rhuss
Copy link
Collaborator

rhuss commented Sep 23, 2015

Thanks a lot !

I adapted it a bit for consistencies sake:

  • Used <kill> instead of <killAfter> to make it simpler. Since the context is the <wait> section it should be somewhat clear what is meant.
  • Used milliseconds instead of second to be consistent with the other time values (time, shutdown).

@rhuss rhuss mentioned this pull request Sep 23, 2015
Closed
@fiji-flo
Copy link
Contributor Author

Nice, thank you.

rhuss added a commit that referenced this pull request Sep 24, 2015
@rhuss
Add some docs for timing in milliseconds but used as seconds.
84a19b8 
See #294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiji-flo @rhuss