Unbreak merge of LogConfiguration config #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any config or property in LogConfiguration is set, enabled shall be true. Before this fix, it was always true.
|
ping @rhuss |
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
============================================
+ Coverage 51.62% 51.67% +0.05%
- Complexity 1351 1358 +7
============================================
Files 147 147
Lines 7446 7448 +2
Branches 1125 1128 +3
============================================
+ Hits 3844 3849 +5
+ Misses 3235 3234 -1
+ Partials 367 365 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #948, bugfix. LogConfiguration was always created with enabled=true, even if no log properties where set.
Desired functionality: if any config or property in LogConfiguration is set, enabled shall be true.
Also added short note to changelog.