Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabric 2.4.0 - toDataURL with clipPath makes objects invisible #5271

Closed
maxim-torba opened this issue Sep 25, 2018 · 11 comments · Fixed by #5278
Closed

fabric 2.4.0 - toDataURL with clipPath makes objects invisible #5271

maxim-torba opened this issue Sep 25, 2018 · 11 comments · Fixed by #5278

Comments

@maxim-torba
Copy link

maxim-torba commented Sep 25, 2018

Version

2.4.0

Test Case

https://jsfiddle.net/maxim_torba/3Lrob45u/24/

Information about environment

chrome, firefox - Ubuntu, Windows - working
chrome, firefox - macOs - not working

Steps to reproduce

If clipPath applied to whole canvas - calling toDataURL makes objects invisible,
if clipPath using for specific object everything is fine.

@rikkarv
Copy link

rikkarv commented Sep 25, 2018

I've tried your fiddle and pasted the console output to browser address bar. What i get is the expected output.
Same result using online decoder:
image

@maxim-torba
Copy link
Author

This is what i have:
screen shot 2018-09-25 at 4 53 10 pm
just transparent png image

@rikkarv
Copy link

rikkarv commented Sep 25, 2018

@maxim-torba when using the online converter you have to remove 'data:image/png;base64,'.

If using browser address bar you include full string with the 'data:,,,' part.

Or you can try your fiddle with the following changes:
https://jsfiddle.net/3Lrob45u/25/

@rikkarv
Copy link

rikkarv commented Sep 25, 2018

image

@maxim-torba
Copy link
Author

@rikkarv yes, i've tried to open it from address bar too (like i said it generating just transparent image), this is what i see in updated fiddle:
screen shot 2018-09-25 at 5 04 05 pm

I've just try it on Ubuntu and Windows and everything is fine, but on macBook it's not working

@rikkarv
Copy link

rikkarv commented Sep 25, 2018

Oh! I'm on windows and perhaps that is why i'm not having problems.
Sorry, i can't debug on macBook.

@maxim-torba
Copy link
Author

Do you have any ideas how it can be related?

@rikkarv
Copy link

rikkarv commented Sep 25, 2018

I have no idea

@maxim-torba
Copy link
Author

@rikkarv thanks, anyway

@yannickguillemot
Copy link

Same issue here. Noticed on mac.

@maxim-torba
Copy link
Author

@yannickguillemot It was fixed in 2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants