Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG caching page not seem to be working #7157

Closed
hamzawain7 opened this issue Jun 25, 2021 · 2 comments · Fixed by #7183
Closed

SVG caching page not seem to be working #7157

hamzawain7 opened this issue Jun 25, 2021 · 2 comments · Fixed by #7183
Labels
bug

Comments

@hamzawain7
Copy link

Version

4.5.1

Test Case

http://fabricjs.com/svg-caching

Information about environment

Nodejs or browser?
Chrome

Steps to reproduce

  1. Goto http://fabricjs.com/svg-caching
  2. SVG caching doesn't seem to animate it smoothly
    ezgif com-gif-maker (3)

Expected Behavior

The tiger SVGs should be animating smoothly
@asturur
Copy link
Member

asturur commented Jun 25, 2021

Something is invalidating the cache periodically, a bug for sure.

@asturur asturur added the bug label Jun 25, 2021
@asturur asturur mentioned this issue Jul 4, 2021
Merged
@asturur
Copy link
Member

asturur commented Jul 4, 2021

This has been fixed, thanks for spotting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(fabric.Object) unnecessary cache invalidation, ISSUE-7157 fabricjs/fabric.js
2 participants
@asturur @hamzawain7