fabric.PatternBrush difference between drawing mode and resulting fabric.Object

[Kienz]

If you draw a fabric.PatternBrush the result during the drawing mode is different to to the created fabric.Path.
You can see this in kitchensink demo - draw one dot (before testing update fabric - see ba2a0e6).

In drawing mode:

After drawing mode (fabric.Path):

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[kangax]

I think I noticed this before as well. Will investigate.

[Kienz]

@kangax Since changing originX/originY to left/top all brushes positioned wrong after mouseUp. You can see it in kitchensink demo.

[kangax]

Great....

[kangax]

Spent couple hours trying to figure this out but without success for now... asked related question on SO. Moving this out of 1.4 for now.

[pstolz]

Are there news for this bug?

[kangax]

Not from me

On Thu, Jan 30, 2014 at 5:53 AM, pstolz notifications@github.com wrote:

Are there news for this bug?

Reply to this email directly or view it on GitHubhttps://github.com//issues/851#issuecomment-33677538
.

[asturur]

it think that in renderStroke we are missing the counterpart of this part of renderFill function:

if (this.fill.toLive) {
        ctx.translate(
          -this.width / 2 + this.fill.offsetX || 0,
          -this.height / 2 + this.fill.offsetY || 0);
      }
}

[asturur]

Ok i found the problem:
The pattern brush has the pattern always aligned to 0,0.
So when we draw it the pattern is not translated.

When the object is actually created, we always do some translation of canvas to place it properly.
I tried to do a ctx.translate for widht/2 and left in all possible combination and permutation, but i did not get any good result.

I think anyway this is the problem.

I was thinking about do the correct translation just in the path _render function, because this problem is tied mainly to drawing mode that produces path, is not a general rule of our rendering pipeline.