Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fabric.Object) unnecessary cache invalidation, ISSUE-7157 #7183

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

asturur
Copy link
Member

@asturur asturur commented Jul 4, 2021

Using a generic method to find out the object scaling is necessary for groups and nested groups, but for alone objects is not needed and will also give sligtly different results depending on the object angle.

On the example of ISSUE-7157, the object would move from a zoom of 1 to 0.999999999999 back and forth depending on the angle and was invalidating cache every a couple of frames

close #7157

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Code Coverage Summary

> fabric@4.5.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.41 |    77.12 |   86.15 |   83.11 |                                               
 fabric.js |   83.41 |    77.12 |   86.15 |   83.11 | ...,29658,29783,29863-29928,30051,30150,30367 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 8d790e9 into master Jul 4, 2021
@asturur asturur deleted the fix-zoom-cache branch August 8, 2021 20:22
@asturur asturur mentioned this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG caching page not seem to be working
1 participant