Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iText): Add optional hiddenTextareaContainer to contain hiddenTextarea #7314

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

rockerBOO
Copy link
Contributor

This is to prevent laggy conditions where the entire body needs to be redrawn. We can attach somewhere else off of the main body tag.

Some details into the scenario but this is a little different due to not making a lot of new elements. But in large pages it can cause additional lag to attach.

const textbox = new Textbox('yo', { hiddenTextareaAppendTo: document.getElementById('hiddenTextarea') })

Not 100% into the long variable name but felt appropriate.

This is to prevent laggy conditions where the entire body needs to
be redrawn. We can attach somewhere else off of the main body tag.
@rockerBOO rockerBOO changed the title feat(itext): Add hiddenTextareaAppendTo to attach textarea to. feat(Textbox): Add hiddenTextareaAppendTo to attach textarea to. Aug 20, 2021
@asturur
Copy link
Member

asturur commented Aug 27, 2021

I like this, is ok, it solves also issues with people using this inside a modal that block any kind of text events from going outside of it

@rockerBOO rockerBOO changed the title feat(Textbox): Add hiddenTextareaAppendTo to attach textarea to. feat(Textbox): Add optional hiddenTextareaContainer to contain hiddenTextarea Aug 27, 2021
@rockerBOO rockerBOO changed the title feat(Textbox): Add optional hiddenTextareaContainer to contain hiddenTextarea feat(iText): Add optional hiddenTextareaContainer to contain hiddenTextarea Aug 27, 2021
@asturur asturur merged commit 9425064 into fabricjs:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants