fix(fabric.StaticCanvas): error of changing read-only style field #7462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Oct 30, 2021
src/static_canvas.class.js
Outdated
| this.lowerCanvasEl.style = this._originalCanvasStyle; | ||
| } | ||
| catch (err) { | ||
| fabric.util.setStyle(this.lowerCanvasEl, this._originalCanvasStyle); |
There was a problem hiding this comment.
if this would work 100% of the time, why not using it as default?
dispose is not a fast operation, even if setStyle is for some reason more complex, is ok.
There was a problem hiding this comment.
Because setStyle is more slow.
I suppose it should be used as a workaround for IE and similar browsers with restrictions.
There was a problem hiding this comment.
this is a slow method, is fine to be always slow. please use setStyle 100% of the time
asturur
approved these changes
Nov 4, 2021
|
Just a clarification that while we are not removing this fix here, probably fabric 5.0 will remove specific workarounds or limitation for ie11. Seems about time. |
rockerBOO
pushed a commit
to rockerBOO/fabric.js
that referenced
this pull request
Nov 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
StaticCanvas.prototype.disposein IE causes "Assignment to read-only properties is not allowed in strict mode" error.The fix eliminates this error.