Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(Canvas#getCenter): migrate to getCenterPoint #7699

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Conversation

ShaMan123
Copy link
Contributor

getCenter doesn't conform with object's getCenterPoint and it should.
This is non breaking, though I think we should remove getCenter right away.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.27 |    76.71 |   86.45 |   82.99 |                                               
 fabric.js |   83.27 |    76.71 |   86.45 |   82.99 | ...,29666,29791,29871-29936,30059,30158,30375 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Feb 18, 2022

This is probably my fault.
Initially my first js days i thought creating an object was better than getting a new point instance.
To be honest i don't thing there is much difference, and if there is, we have to stick with it for consistency sake

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.28 |    76.71 |   86.52 |      83 |                                               
 fabric.js |   83.28 |    76.71 |   86.52 |      83 | ...,29666,29791,29871-29936,30059,30158,30375 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 3d4d81c into master Feb 18, 2022
@ShaMan123 ShaMan123 deleted the canvas-get-center branch February 19, 2022 06:41
@asturur asturur mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants