chore(v6): TypeScript proto #7839

ShaMan123 · 2022-03-29T12:32:45Z

Introduce a transformer that is able to convert most of the files under src into es6/ts and produces a good diff on git when preserving the file names (changing the extension is OK by git).

Relevant changes

scripts/transform_file.js - the transformer logic
scripts/index.js - expose cmd for cli (npm run dev transform -- --help)
src files were committed to show the diff - they shouldn't be accepted into master yet
build.js - 3e8cf5f reverted the following:
The build file can do the following:
1. compile ts/js files from src to dist
2. build fabric.js from compiled files.
src/util/anim_ease.ts is a manual converted file

build needs to be replaced and babel introduced

* init typescript * Create Rect.ts * Update Rect.ts * Update package.json * Update tsconfig.json * Update Rect.ts

github-actions · 2022-03-29T13:11:20Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------

This reverts commit 7428b03.

github-actions · 2022-03-29T13:13:52Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------

github-actions · 2022-03-29T13:15:59Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------

package.json

asturur · 2022-04-01T21:34:26Z

@ShaMan123 as soon as the group pr is merged, we can start this.
My plan is:
first pr:

convert 1 file that has only functions ( easing file is a good example )
get a new eslint config that support ts syntax and tslint config
choose the basic transpile target ( cant' be es5 )
choose the new bundler / packager ( because the old build script won't work since wrapping function won't be there and so it will pollute the global space, or modify the current one to work.
no classes, no mixins nothing

then we rotate a class per pr, possibly let's involve whoever wants to convert, so that everyone can get dirty hands and get comfortable with the process. I want to do at least one.

ShaMan123 · 2022-04-01T22:29:02Z

sounds good to me

ShaMan123 · 2022-04-10T08:58:59Z

should use tsc --watch option as it is incremental

commit b22237c Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jun 12 00:12:17 2022 +0300 Update transform_file.js commit 79beda5 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jun 12 00:10:39 2022 +0300 Update transform_file.js commit afb477d Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jun 12 00:09:09 2022 +0300 Update transform_file.js commit 2c44f80 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jun 12 00:04:05 2022 +0300 Update index.js commit 42de37a Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jun 12 00:02:28 2022 +0300 Update index.js commit 1c7cd0a Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:59:06 2022 +0300 Update transform_file.js commit c6bb365 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:48:52 2022 +0300 Update index.js commit a978def Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:47:06 2022 +0300 expose on cli commit 25f5282 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:29:41 2022 +0300 Update transform_file.js commit 69f5810 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:21:34 2022 +0300 Update transform_file.js commit a1af13c Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:08:22 2022 +0300 Update transform_file.js commit d68a89e Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:07:10 2022 +0300 Update transform_file.js commit 98e3e12 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 23:06:26 2022 +0300 fix "fix NS var usage" This fixes a regression made by commit af1aa03. commit af1aa03 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 22:31:37 2022 +0300 fix NS var usage commit a32ee7b Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 22:00:27 2022 +0300 Update transform_file.js commit 7475b75 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 21:57:54 2022 +0300 Update transform_file.js commit dc90fe8 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 21:57:36 2022 +0300 Update transform_file.js commit 8cd097c Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 21:43:24 2022 +0300 Update transform_file.js commit ca4a619 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 21:17:49 2022 +0300 build passes commit a8ed02a Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 21:16:23 2022 +0300 Update transform_file.js commit d408f4d Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 19:45:55 2022 +0300 fix comments bug commit 1c95448 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 19:23:50 2022 +0300 Update transform_file.js commit f69f37b Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 19:14:17 2022 +0300 Update transform_file.js commit 48aefbe Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 19:12:04 2022 +0300 Update transform_file.js commit 0416ea2 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 19:02:19 2022 +0300 Update transform_file.js commit ec4b362 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:59:31 2022 +0300 Update transform_file.js commit 5a4fc01 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:51:30 2022 +0300 revert commit 0f36da9 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:48:40 2022 +0300 Update transform_file.js commit 4bdbb5d Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:45:18 2022 +0300 Update transform_file.js commit a4adba8 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:44:36 2022 +0300 Update transform_file.js commit 41a1dff Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:43:12 2022 +0300 Update transform_file.js commit 8257bc6 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:41:47 2022 +0300 Update transform_file.js commit 953a020 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:34:06 2022 +0300 Update transform_file.js commit cff5157 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:31:58 2022 +0300 Update transform_file.js commit d0b1835 Author: ShaMan123 <shacharnen@gmail.com> Date: Sat Jun 11 18:27:53 2022 +0300 revert ts change

ShaMan123

@asturur @melchiar take a look at 04be3f5 (it is only a POC - after we merge all the PRs we should rerun the transformer)! I managed to build a transformer that works pretty good. I'm really happy about it (accept for the horrible time sink)!
And I saw something very exciting in VSCODE:

group.class.ts.-.fabric.js.-.Visual.Studio.Code.2022-06-12.00-25-29.mp4

Then human work can be much easier:

static properties - too hard to impl in transformer
imports/export/build/
sub/super/abstract class
cleanup
types
private/protected - can be done with the transformer
things missed out by the transformer (see dump.txt)

OHHH
Forgot this:
Run npm run dev transform to run the transformer (it will fail for transformed files - revert the transformation commit 04be3f5 before running the cmd)

This reverts commit f9ed7ba.

This reverts commit 4699505.

ShaMan123 · 2022-06-12T08:40:28Z

Transforming PRs is now possible!
I have tested the following:

mock merging a PR into master (merged deprecate-extend into test-pr-transform)
ran npm run dev transform -- -ts -o --diff
committed changes 0b6da98
merged branch into mocked transformed master 656bc9d (merged test-pr-transform into ts-proto)
resolved conflicts

The conflicts were simple and weren't affected by the conversion.

ShaMan123

The transformer is in a good state
We can revert the changes to src and dist and merge this PR as it only changes scripts

ShaMan123 · 2022-06-12T09:10:05Z

updated description

ShaMan123 · 2022-06-23T06:30:32Z

closing in favor of #8020

ShaMan123 and others added 8 commits March 29, 2022 14:45

chore(TypeScript): proto (#7838)

34e5f33

* init typescript * Create Rect.ts * Update Rect.ts * Update package.json * Update tsconfig.json * Update Rect.ts

Update tsconfig.json

787e261

Update build.js

d5a437c

Update build.js

f8cfeeb

test

215ac9b

Update .gitignore

0956d59

types 👍

ab92e12

Update anim_ease.ts

eacb5d3

ShaMan123 requested review from melchiar and asturur March 29, 2022 12:42

ShaMan123 added 4 commits March 29, 2022 15:53

bump uglifyjs

edcd933

var -> let

72e9d2c

Update anim_ease.ts

4a3fd88

bind methods

5894f05

ShaMan123 marked this pull request as ready for review March 29, 2022 13:09

ShaMan123 added 2 commits March 29, 2022 16:11

Update package-lock.json

7428b03

Revert "Update package-lock.json"

fbb7480

This reverts commit 7428b03.

ShaMan123 marked this pull request as draft March 29, 2022 13:14

modules

ac9cfad

asturur reviewed Apr 1, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

ShaMan123 changed the title ~~chore(v6):TypeScript proto~~ chore(v6): TypeScript proto Apr 21, 2022

ShaMan123 added the v6 label Apr 23, 2022

ShaMan123 added 2 commits June 11, 2022 07:22

Create transform_file.js

b8f1450

Update transform_file.js

f73b08d

ShaMan123 added 2 commits June 12, 2022 00:18

auto migrate POC

f9ed7ba

ShaMan123 force-pushed the ts-proto branch from b6df144 to f9ed7ba Compare June 11, 2022 21:18

ShaMan123 commented Jun 11, 2022

View reviewed changes

ShaMan123 added 15 commits June 12, 2022 01:37

better cli

146b407

select files

34f0cc2

Revert "auto migrate POC"

fe6f533

This reverts commit f9ed7ba.

auto migrate POC

04be3f5

chore(): move away from extend

c1cdc6d

chore(): replace shallow clone/extend

1d10bfa

chore(): remove redundant(?) cloning

949bd8f

fix(): lint

e8cdea6

transform file

4699505

Revert "transform file"

652427c

This reverts commit 4699505.

transform file

79d5b07

git actions

c80ec7b

auto transform pr

0b6da98

Update index.js

22002ca

Merge branch 'test-pr-transform' into ts-proto

656bc9d

ShaMan123 commented Jun 12, 2022

View reviewed changes

ShaMan123 mentioned this pull request Jun 19, 2022

ci(): switch the old custom build for rollup #8013

Merged

ShaMan123 added 3 commits June 23, 2022 08:41

checkout

6baae55

Merge branch 'master' into ts-proto

c2ad95a

fix(transformer): move JSDOC to class

224497d

ShaMan123 mentioned this pull request Jun 23, 2022

ci(typescript): transformer #8020

Merged

ShaMan123 closed this Jun 23, 2022

ShaMan123 deleted the ts-proto branch September 12, 2022 00:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(v6): TypeScript proto #7839

chore(v6): TypeScript proto #7839

ShaMan123 commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

asturur commented Apr 1, 2022

ShaMan123 commented Apr 1, 2022

ShaMan123 commented Apr 10, 2022

ShaMan123 left a comment •

edited

Loading

ShaMan123 commented Jun 12, 2022 •

edited

Loading

ShaMan123 left a comment •

edited

Loading

ShaMan123 commented Jun 12, 2022

ShaMan123 commented Jun 23, 2022

chore(v6): TypeScript proto #7839

chore(v6): TypeScript proto #7839

Conversation

ShaMan123 commented Mar 29, 2022 • edited Loading

Relevant changes

github-actions bot commented Mar 29, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Mar 29, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Mar 29, 2022 • edited Loading

Code Coverage Summary

asturur commented Apr 1, 2022

ShaMan123 commented Apr 1, 2022

ShaMan123 commented Apr 10, 2022

ShaMan123 left a comment • edited Loading

Choose a reason for hiding this comment

ShaMan123 commented Jun 12, 2022 • edited Loading

ShaMan123 left a comment • edited Loading

Choose a reason for hiding this comment

ShaMan123 commented Jun 12, 2022

ShaMan123 commented Jun 23, 2022

ShaMan123 commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

ShaMan123 left a comment •

edited

Loading

ShaMan123 commented Jun 12, 2022 •

edited

Loading

ShaMan123 left a comment •

edited

Loading