-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Layer): 3rd Patch of Group Rewrite ♦️ #7860
Conversation
in case object is a collection
Code Coverage Summary
|
Code Coverage Summary
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAJOR update from master
7860.diff.txt from before
Layer
This is pretty straight forward.
Subclass of Group.
Adapted layout logic to fit Layer's needs
Added logic in Group to support nesting Layer.
This is AMAZING because Layer can now be used to boost perf. We can split a canvas/group's objects into 2 sub collections, one for active objects and one for non active ones. We can then use Layer to render all the non actives and have it cached while setting group not to cache.
Gist
Layer will layout itself once it is added to a collection and by listening to it's parent layouts
resize
event (from thesetDimensions
method - should we listen to anything else?MutationObserver
works both on web/node)layout
eventDev
Merge the 2nd patch, update from master and then merge this one.View the diffcloses #3000
closes #7692
https://fx32zv.csb.app/
Cutting Edge
Read the comments below to see what can be achieved using Layer: