Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Group): render selected objects #7863

Closed
wants to merge 39 commits into from
Closed

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Apr 4, 2022

This is here to hold the _renderObjects logic in case we shall need it
View diff

@ShaMan123 ShaMan123 changed the title feat(Group): render selected object feat(Group): render selected objects Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.97 |    76.03 |   85.66 |    82.7 |                                               
 fabric.js |   82.97 |    76.03 |   85.66 |    82.7 | ...,30637,30762,30842-30907,31030,31129,31365 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 added the group label Apr 4, 2022
@ShaMan123 ShaMan123 mentioned this pull request Apr 9, 2022
48 tasks
@ShaMan123
Copy link
Contributor Author

ShaMan123 commented Apr 16, 2022

closing this in favor of a simpler approach

- this._objects[i].render(ctx);
+ this._objects[i].group === this && this._objects[i].render(ctx);

if object is part of active selection it's group property will be equal to the active selection

@ShaMan123 ShaMan123 closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant