fix(): stop transforming on discardActiveObject

src/canvas.class.js

@@ -1229,7 +1229,7 @@
     /**
      * This is a private method for now.
      * This is supposed to be equivalent to discardActiveObject but without firing
-     * any events. There is commitment to have this stay this way.
+     * any selection events ( can still fire object transformation events ). There is commitment to have this stay this way.
      * This is the functional part of discardActiveObject.
      * @param {Event} [e] Event (passed along when firing "object:deselected")
      * @param {Object} object to set as active
@@ -1243,6 +1243,9 @@
         if (obj.onDeselect({ e: e, object: object })) {
           return false;
         }
+        if (this._currentTransform && this._currentTransform.target === obj) {
+          this.endCurrentTransform(e);
+        }
         this._activeObject = null;
       }
       return true;

src/mixins/canvas_events.mixin.js

@@ -565,6 +565,22 @@
       }
     },
 
+    /**
+     * End the current transfrom.
+     * You don't usually need to call this method unless you are interupting a user initiated transform
+     * because of some other event ( a press of key combination, or something that block the user UX )
+     * @param {Event} [e] send the mouse event that generate the finalize down, so it can be used in the event
+     */
+    endCurrentTransform: function(e) {
+      var transform = this._currentTransform;
+      this._finalizeCurrentTransform(e);
+      if (transform && transform.target) {
+        // this could probably go inside _finalizeCurrentTransform
+        transform.target.isMoving = false;
+      };
+      this._currentTransform = null;
+    },
+
     /**
      * @private
      * @param {Event} e send the mouse event that generate the finalize down, so it can be used in the event

test/unit/canvas.js

@@ -1977,7 +1977,20 @@
     canvas.setActiveObject(canvas.item(0));
 
     canvas._discardActiveObject();
-    assert.ok(!canvas.item(0).active);
+    assert.equal(canvas.getActiveObject(), null);
+  });
+
+  QUnit.test('_discardActiveObject - cleanup transform', function (assert) {
+    var e = { clientX: 5, clientY: 5, which: 1, target: canvas.upperCanvasEl };
+    var target = makeRect();
+    canvas.add(target);
+    canvas.setActiveObject(target);
+    canvas._setupCurrentTransform(e, target, true);
+    assert.ok(canvas._currentTransform, 'transform should be set');
+    target.isMoving = true;
+    canvas._discardActiveObject();
+    assert.ok(!canvas._currentTransform, 'transform should be cleared');
+    assert.ok(!target.isMoving, 'moving flag should have been negated');
     assert.equal(canvas.getActiveObject(), null);
   });
 
@@ -2003,7 +2016,6 @@
     });
 
     canvas.discardActiveObject();
-    assert.ok(!canvas.item(0).active);
     assert.equal(canvas.getActiveObject(), null);
     assert.equal(canvas.getActiveObject(), null);