-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Group): 🛠️ layout, angle and origin ⚡ #8004
Conversation
Code Coverage Summary
|
Those tests are useful, but we need them to have less transparent pixels if we want the detection to work. We need to scale up the group and have it fill up more image |
Code Coverage Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
READY!
percentage: 0.06, | ||
width: 300, | ||
height: 300 | ||
percentage: 0.001, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I calculated this percent to be exactly the red/blue origin indicators.
Now after resizing goldens it will be even more sensitive. Which is good.
READY TO MERGE!
i wanted to make the drawing bigger, so that the eyes could catch easily what is wrong ( if any ) and we don't have to rely on few pixel differences of different aliasing. |
for sure. |
This PR replaces the polluted #7867
Group now respects originX/Y + angle/skewing!
It is a minor fix (to the layout engine) but a significant one.
I have committed all binaries (accept 2) in a single commit so you can view the diff without them.
There are some conflicts with #7860
so we better merge that first (because conflicts are resolved there) or perhaps extract group logic and merge that.