Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Group): 🛠️ layout, angle and origin ⚡ #8004

Merged
merged 8 commits into from
Jun 15, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Jun 13, 2022

This PR replaces the polluted #7867

Group now respects originX/Y + angle/skewing!
It is a minor fix (to the layout engine) but a significant one.
I have committed all binaries (accept 2) in a single commit so you can view the diff without them.

There are some conflicts with #7860 so we better merge that first (because conflicts are resolved there) or perhaps extract group logic and merge that.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.16 |    76.08 |   85.76 |   82.88 |                                               
 fabric.js |   83.16 |    76.08 |   85.76 |   82.88 | ...,30851,30925,30936-31001,31124,31223,31459 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Jun 13, 2022

Those tests are useful, but we need them to have less transparent pixels if we want the detection to work. We need to scale up the group and have it fill up more image

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.16 |    76.08 |   85.76 |   82.88 |                                               
 fabric.js |   83.16 |    76.08 |   85.76 |   82.88 | ...,30851,30925,30936-31001,31124,31223,31459 
-----------|---------|----------|---------|---------|-----------------------------------------------

Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READY!

percentage: 0.06,
width: 300,
height: 300
percentage: 0.001,
Copy link
Contributor Author

@ShaMan123 ShaMan123 Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I calculated this percent to be exactly the red/blue origin indicators.
Now after resizing goldens it will be even more sensitive. Which is good.

READY TO MERGE!

@asturur
Copy link
Member

asturur commented Jun 15, 2022

i wanted to make the drawing bigger, so that the eyes could catch easily what is wrong ( if any ) and we don't have to rely on few pixel differences of different aliasing.
But i m sure that if i look at the test i can do that easily later

@ShaMan123
Copy link
Contributor Author

for sure.

@ShaMan123 ShaMan123 merged commit d57f350 into master Jun 15, 2022
@ShaMan123 ShaMan123 deleted the v6-fix-group-layout-angle-origin branch September 11, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants